----==_mimepart_69679e3a9f33a_26617a2afbc97ad9ac59811
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Hi,
Please find the latest report on new defect(s) introduced to Synchronet found with Coverity Scan.
113 new defect(s) introduced to Synchronet found with Coverity Scan.
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
New defect(s) Reported-by: Coverity Scan
Showing 20 of 113 defect(s)
** CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3499 in alias()
_____________________________________________________________________________________________
*** CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3499 in alias()
3493
3494 if (*tp == 0) /* no alias value */
3495 continue;
3496 *tp = 0;
3497
3498 vp = tp + 1;
CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*vp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3499 SKIP_WHITESPACE(vp);
3500 truncsp(vp);
3501 if (*vp == 0) /* no value */
3502 continue;
3503
3504 if (*np == '*') {
** CID 641218: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 3761 in ctrl_thread()
/ftpsrvr.c: 4084 in ctrl_thread()
_____________________________________________________________________________________________
*** CID 641218: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 3761 in ctrl_thread()
3755 tp = np; /* terminator pointer */
3756 FIND_WHITESPACE(tp);
3757 if (*tp)
3758 *tp = 0;
3759
3760 dp = tp + 1; /* description pointer */
CID 641218: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*dp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3761 SKIP_WHITESPACE(dp);
3762 truncsp(dp);
3763
3764 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
3765 continue;
3766
/ftpsrvr.c: 4084 in ctrl_thread()
4078 tp = np; /* terminator pointer */
4079 FIND_WHITESPACE(tp); 4080 if (*tp)
4081 *tp = 0;
4082
4083 dp = tp + 1; /* description pointer */
CID 641218: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*dp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
4084 SKIP_WHITESPACE(dp); 4085 truncsp(dp);
4086
4087 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
4088 continue;
4089
** CID 641217: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 353 in smb_netaddr_type() /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 343 in smb_netaddr_type()
_____________________________________________________________________________________________
*** CID 641217: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 353 in smb_netaddr_type()
347 return NET_FIDO;
348 return NET_NONE;
349 }
350 if (p == str)
351 return NET_UNKNOWN;
352 p++;
CID 641217: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
353 SKIP_WHITESPACE(p);
354 if (*p == 0)
355 return NET_UNKNOWN;
356
357 type = smb_get_net_type_by_addr(p);
358 if (type == NET_INTERNET && strchr(str, ' ') != NULL) /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 343 in smb_netaddr_type()
337 const char* p;
338
339 if (str == NULL || IS_WHITESPACE(*str))
340 return NET_NONE;
341 if ((p = strchr(str, '@')) == NULL) {
342 p = str;
CID 641217: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
343 SKIP_WHITESPACE(p);
344 if (*p == 0)
345 return NET_NONE;
346 if (smb_get_net_type_by_addr(p) == NET_FIDO)
347 return NET_FIDO;
348 return NET_NONE;
** CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 6561 in read_areafile_bbs()
_____________________________________________________________________________________________
*** CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 6561 in read_areafile_bbs()
6555 lprintf(LOG_ERR, "ERROR allocating memory for area #%u.", cfg.areas + 1);
6556 bail(1);
6557 return;
6558 }
6559 sprintf(tmp_code, "%-.*s", LEN_EXTCODE, p);
6560 tp = tmp_code;
CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
6561 FIND_WHITESPACE(tp);
6562 *tp = '\0';
6563 for (i = 0; i < scfg.total_subs; i++)
6564 if (!stricmp(tmp_code, scfg.sub[i]->code))
6565 break;
6566 if (i < scfg.total_subs)
** CID 641215: (CONSTANT_EXPRESSION_RESULT)
/un_rep.cpp: 567 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 554 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 570 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 569 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 552 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 555 in sbbs_t::unpack_rep(char *)()
_____________________________________________________________________________________________
*** CID 641215: (CONSTANT_EXPRESSION_RESULT)
/un_rep.cpp: 567 in sbbs_t::unpack_rep(char *)()
561 subscan[n].cfg |= SUB_CFG_NSCAN | SUB_CFG_YSCAN;
562 }
563 continue;
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) { 566 p = str + 6;
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
569 FIND_WHITESPACE(p);
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0) /un_rep.cpp: 554 in sbbs_t::unpack_rep(char *)()
548 if (!fgets(str, sizeof(str) - 1, fp)) 549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) { 551 p = str + 5;
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
554 FIND_WHITESPACE(p);
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
558 else if (strchr(p, 'a') || strchr(p, 'g'))
559 subscan[n].cfg |= SUB_CFG_NSCAN;
/un_rep.cpp: 570 in sbbs_t::unpack_rep(char *)()
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) { 566 p = str + 6;
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
569 FIND_WHITESPACE(p);
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0)
573 subscan[n].ptr = 0;
574 else {
575 /* otherwise it should be set back [#ofmessages] back from the end of the message base. */
/un_rep.cpp: 569 in sbbs_t::unpack_rep(char *)()
563 continue;
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) { 566 p = str + 6;
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
569 FIND_WHITESPACE(p);
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0)
573 subscan[n].ptr = 0;
574 else {
/un_rep.cpp: 552 in sbbs_t::unpack_rep(char *)()
546 if (fp != NULL) {
547 while (!feof(fp)) {
548 if (!fgets(str, sizeof(str) - 1, fp)) 549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) { 551 p = str + 5;
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
554 FIND_WHITESPACE(p);
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
/un_rep.cpp: 555 in sbbs_t::unpack_rep(char *)()
549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) { 551 p = str + 5;
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
554 FIND_WHITESPACE(p);
CID 641215: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
558 else if (strchr(p, 'a') || strchr(p, 'g'))
559 subscan[n].cfg |= SUB_CFG_NSCAN;
560 else if (strchr(p, 'p'))
** CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1603 in check_elists()
_____________________________________________________________________________________________
*** CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1603 in check_elists()
1597 break;
1598 p = str;
1599 SKIP_WHITESPACE(p); 1600 if (*p == ';') /* Ignore Comment Lines */
1601 continue;
1602 tp = p;
CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1603 FIND_WHITESPACE(tp); 1604 *tp = '\0';
1605 if (!stricmp(areatag, p)) {
1606 match = true; 1607 break;
1608 }
** CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3492 in alias()
_____________________________________________________________________________________________
*** CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3492 in alias()
3486 break;
3487 np = line;
3488 SKIP_WHITESPACE(np);
3489 if (*np == ';' || *np == 0) /* no name value, or comment */
3490 continue;
3491 tp = np;
CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3492 FIND_WHITESPACE(tp);
3493
3494 if (*tp == 0) /* no alias value */
3495 continue;
3496 *tp = 0;
3497
** CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1531 in netmail_arealist()
_____________________________________________________________________________________________
*** CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1531 in netmail_arealist()
1525 truncsp(str);
1526 p = str;
1527 SKIP_WHITESPACE(p);
1528 if (*p == 0 || *p == ';') /* Ignore Blank and Comment Lines */
1529 continue;
1530 tp = p; >>> CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1531 FIND_WHITESPACE(tp);
1532 *tp = '\0';
1533 if (find_linked_area(p, addr) == SUB_NOT_FOUND) {
1534 if (strListFind(area_list, p, /* case_sensitive */ false) < 0)
1535 strListPush(&area_list, p);
1536 }
** CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 232 in key_name()
_____________________________________________________________________________________________
*** CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 232 in key_name()
226 *vp = NULL;
227
228 if (p == NULL)
229 return NULL;
230
231 /* Parse value name */
CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
232 SKIP_WHITESPACE(p);
233 if (*p == INI_COMMENT_CHAR)
234 return NULL;
235 if (*p == INI_OPEN_SECTION_CHAR)
236 return INI_NEW_SECTION;
237 equal = strchr(p, '=');
** CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /wordwrap.c: 211 in get_ws_len()
_____________________________________________________________________________________________
*** CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /wordwrap.c: 211 in get_ws_len()
205 {
206 struct section_len ret = {0, 0};
207
208 for (ret.bytes = 0; ; ret.bytes++) {
209 if (!buf[ret.bytes])
210 break;
CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)buf[ret.bytes] == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
211 if (!IS_WHITESPACE(buf[ret.bytes]))
212 break;
213 if (buf[ret.bytes] == '\t') {
214 ret.len++;
215 while ((ret.len + col) % 8)
216 ret.len++;
** CID 641209: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 83 in section_name() /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 87 in section_name()
_____________________________________________________________________________________________
*** CID 641209: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 83 in section_name()
77 }
78
79 static char* section_name(char* p)
80 {
81 char* tp;
82
CID 641209: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
83 SKIP_WHITESPACE(p);
84 if (*p != INI_OPEN_SECTION_CHAR)
85 return NULL;
86 p++;
87 SKIP_WHITESPACE(p);
88 tp = strrchr(p, INI_CLOSE_SECTION_CHAR); /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 87 in section_name()
81 char* tp;
82
83 SKIP_WHITESPACE(p);
84 if (*p != INI_OPEN_SECTION_CHAR)
85 return NULL;
86 p++;
CID 641209: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
87 SKIP_WHITESPACE(p);
88 tp = strrchr(p, INI_CLOSE_SECTION_CHAR);
89 if (tp == NULL)
90 return NULL;
91 *tp = 0;
92 truncsp(p);
** CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1989 in parse_mail_address(const char *, char *, unsigned long, char *, unsigned long)()
_____________________________________________________________________________________________
*** CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1989 in parse_mail_address(const char *, char *, unsigned long, char *, unsigned long)()
1983
1984 /* Get the address */
1985 if ((tp = (char*)strchr(p, '<')) != NULL)
1986 tp++;
1987 else
1988 tp = (char*)p;
CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1989 SKIP_WHITESPACE(tp);
1990 sprintf(addr, "%.*s", (int)addr_len, tp);
1991 truncstr(addr, ">( ");
1992
1993 if (name != NULL) {
1994 SAFECOPY(tmp, p);
** CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 2496 in process_areamgr()
_____________________________________________________________________________________________
*** CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 2496 in process_areamgr()
2490 }
2491
2492 m = strlen(p);
2493 add_area = strListInit();
2494 del_area = strListInit();
2495 for (l = 0; l < m; l++) {
CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)p[l] == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2496 while (*(p + l) && IS_WHITESPACE(*(p + l))) l++;
2497 while (*(p + l) == CTRL_A) { /* Ignore kludge lines June-13-2004 */
2498 while (*(p + l) && *(p + l) != '\r') l++;
2499 continue;
2500 }
2501 if (!(*(p + l)))
** CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 118 in section_match()
_____________________________________________________________________________________________
*** CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 118 in section_match() 112 /* Search for matches */
113 for (i = 0; names[i] != NULL && !found; i++)
114 for (j = 0; comps[j] != NULL && !found; j++) {
115 n = names[i];
116 SKIP_WHITESPACE(n);
117 c = comps[j];
CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*c == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
118 SKIP_WHITESPACE(c);
119 if (case_sensitive)
120 found = strcmp(n, c) == 0;
121 else
122 found = stricmp(n, c) == 0;
123 }
** CID 641205: (CONSTANT_EXPRESSION_RESULT)
/sbbsecho.c: 2225 in areamgr_command()
/sbbsecho.c: 2191 in areamgr_command()
/sbbsecho.c: 2224 in areamgr_command()
/sbbsecho.c: 2335 in areamgr_command()
/sbbsecho.c: 2156 in areamgr_command()
/sbbsecho.c: 2273 in areamgr_command()
/sbbsecho.c: 2192 in areamgr_command()
/sbbsecho.c: 2336 in areamgr_command()
/sbbsecho.c: 2250 in areamgr_command()
/sbbsecho.c: 2155 in areamgr_command()
/sbbsecho.c: 2274 in areamgr_command()
/sbbsecho.c: 2306 in areamgr_command()
/sbbsecho.c: 2249 in areamgr_command()
_____________________________________________________________________________________________
*** CID 641205: (CONSTANT_EXPRESSION_RESULT)
/sbbsecho.c: 2225 in areamgr_command()
2219 }
2220
2221 if (strnicmp(instr, "PKTPWD ", 7) == 0) {
2222 char pktpwd[FIDO_PASS_LEN + 1]; /* Packet password for this node */
2223 char* p = instr;
2224 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2225 SKIP_WHITESPACE(p);
2226 SAFECOPY(pktpwd, p);
2227 if (!stricmp(pktpwd, nodecfg->pktpwd)) {
2228 snprintf(str, sizeof str, "Your packet password was already set to '%s'."
2229 , nodecfg->pktpwd);
2230 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2191 in areamgr_command()
2185 return true;
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2191 FIND_WHITESPACE(p);
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2224 in areamgr_command()
2218 return true;
2219 }
2220
2221 if (strnicmp(instr, "PKTPWD ", 7) == 0) {
2222 char pktpwd[FIDO_PASS_LEN + 1]; /* Packet password for this node */
2223 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2224 FIND_WHITESPACE(p);
2225 SKIP_WHITESPACE(p);
2226 SAFECOPY(pktpwd, p);
2227 if (!stricmp(pktpwd, nodecfg->pktpwd)) {
2228 snprintf(str, sizeof str, "Your packet password was already set to '%s'."
2229 , nodecfg->pktpwd);
/sbbsecho.c: 2335 in areamgr_command()
2329 , str, /* dest: */ addr, /* src: */ NULL);
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2335 FIND_WHITESPACE(p);
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
/sbbsecho.c: 2156 in areamgr_command()
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
2155 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE;
2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++)
2161 if (stricmp(p, cfg.arcdef[u].name) == 0)
/sbbsecho.c: 2273 in areamgr_command()
2267 create_netmail(to, /* msg: */ NULL, "TIC File Password Change Request", str, /* dest: */ addr, /* src: */ NULL);
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2273 FIND_WHITESPACE(p);
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) {
2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
/sbbsecho.c: 2192 in areamgr_command()
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
2191 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
2197 create_netmail(to, /* msg: */ NULL, "AreaMgr Password Change Request", str
/sbbsecho.c: 2336 in areamgr_command()
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
2335 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
2341 FILE* fp;
/sbbsecho.c: 2250 in areamgr_command()
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
2249 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);
2255 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2155 in areamgr_command()
2149 lprintf(LOG_INFO, "AreaMgr (for %s) Changing name to: %s", faddrtoa(&addr), to);
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2155 FIND_WHITESPACE(p);
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE;
2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++)
/sbbsecho.c: 2274 in areamgr_command()
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
2273 FIND_WHITESPACE(p);
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) {
2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
2279 SAFECOPY(str, "Error changing Notify Setting"); /sbbsecho.c: 2306 in areamgr_command()
2300 return true;
2301 }
2302
2303 // %RESCAN <area-tag> [R=<count> || D=<days>]
2304 if (strnicmp(instr, "RESCAN ", 7) == 0) {
2305 char* p = instr + 7;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2306 SKIP_WHITESPACE(p);
2307 char* tp = p;
2308 FIND_WHITESPACE(tp);
2309 if (*tp != '\0') {
2310 *tp = '\0';
2311 ++tp;
/sbbsecho.c: 2249 in areamgr_command()
2243 return true;
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
CID 641205: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2249 FIND_WHITESPACE(p);
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);
** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()
_____________________________________________________________________________________________
*** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()
5743 /* ToDo: Make ident timeout configurable */
5744 if (identify(&client_addr, inet_addrport(&client_addr), str, sizeof(str) - 1, /* timeout: */ 1)) {
5745 lprintf(LOG_DEBUG, "%04d %s [%s] Ident Response: %s", client_socket, client.protocol, host_ip, str);
5746 identity = strrchr(str, ':'); 5747 if (identity != NULL) {
5748 identity++; /* skip colon */
CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*identity == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
5749 SKIP_WHITESPACE(identity);
5750 if (*identity)
5751 lprintf(LOG_INFO, "%04d %s [%s] Identity: %s", client_socket, client.protocol, host_ip, identity);
5752 }
5753 }
5754 sbbs->cp437_out(crlf);
** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
_____________________________________________________________________________________________
*** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;
428 continue;
429 }
430 if (strncmp(p, "Subject:", 8) == 0) {
431 p += 8;
CID 641203: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
432 SKIP_WHITESPACE(p);
433 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
434 if (tp != NULL)
435 *tp = 0;
436 subject = p;
437 p += strlen(p) + 1;
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
416 SAFECOPY(to, into);
417
418 // Parse QWKE Kludge Lines here:
419 while (p < end && *p != QWK_NEWLINE) {
420 if (strncmp(p, "To:", 3) == 0) {
421 p += 3;
CID 641203: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
422 SKIP_WHITESPACE(p);
423 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
424 if (tp != NULL)
425 *tp = 0;
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;
** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()
_____________________________________________________________________________________________
*** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()
1954 continue;
1955
1956 sprintf(list, "%.100s", p);
1957
1958 /* terminate */
1959 tp = p;
CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1960 FIND_WHITESPACE(tp);
1961 *tp = 0;
1962
1963 found = rblchk(sock, prot, addr, p);
1964 }
1965 fclose(fp);
** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
_____________________________________________________________________________________________
*** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1179 break;
1180 }
1181
1182 /* Get destination user address */
1183 if ((p = strrchr(rcpt_list[rcpt_count], '<')) != NULL) {
1184 p++;
CID 641201: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1185 SKIP_WHITESPACE(p);
1186 SAFECOPY(addr, p);
1187 p = strrchr(addr, '>');
1188 if (p == NULL) {
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
1191 }
1192 *p = 0;
1193 } else {
1194 p = rcpt_list[rcpt_count];
CID 641201: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1195 SKIP_WHITESPACE(p);
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
969 bprintf(text[InvalidNetMailAddr], p);
970 continue;
971 }
972 while (at > p && *at > ' ')
973 at--;
974 p = at;
CID 641201: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
975 SKIP_WHITESPACE(p);
976 uint16_t net_type = smb_netaddr_type(p);
977 if (net_type != NET_INTERNET) {
978 bprintf(text[InvalidNetMailAddr], p);
979 break;
980 }
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
1201 p = rcpt_list[rcpt_count];
CID 641201: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1202 SKIP_WHITESPACE(p);
1203 SAFECOPY(name, p);
1204 p = strrchr(name, '<');
1205 if (!p)
1206 p = strrchr(name, '@');
1207 if (!p)
** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
/ftpsrvr.c: 1547 in ftpalias()
_____________________________________________________________________________________________
*** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
1528
1529 while (!feof(fp)) {
1530 if (!fgets(line, sizeof(line), fp))
1531 break;
1532
1533 p = line; /* alias */
CID 641200: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1534 SKIP_WHITESPACE(p);
1535 if (*p == ';') /* comment */
1536 continue;
1537
1538 tp = p; /* terminator */
1539 FIND_WHITESPACE(tp);
/ftpsrvr.c: 1547 in ftpalias()
1541 *tp = 0;
1542
1543 if (stricmp(p, alias)) /* Not a match */
1544 continue;
1545
1546 p = tp + 1; /* filename */
CID 641200: (CONSTANT_EXPRESSION_RESULT)
"(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1547 SKIP_WHITESPACE(p);
1548
1549 tp = p; /* terminator */
1550 FIND_WHITESPACE(tp);
1551 if (*tp)
1552 *tp = 0;
________________________________________________________________________________________________________
To view the defects in Coverity Scan visit,
https://scan.coverity.com/projects/synchronet?tab=overview
----==_mimepart_69679e3a9f33a_26617a2afbc97ad9ac59811
Content-Type: text/html; charset=us-ascii
Content-Transfer-Encoding: 7bit
<!DOCTYPE html>
<html>
<head>
<meta charset="UTF-8">
<title>New Defects Reported - Synchronet</title>
<style>
body { font-family: Arial, sans-serif; color: #222; line-height: 1.6; }
.button {
display: inline-block;
padding: 10px 20px;
margin: 20px 0;
font-size: 16px;
color: #fff !important;
background-color: #0056b3;
text-decoration: none;
border-radius: 5px;
}
pre {
background: #f8f9fa;
padding: 10px;
border-radius: 5px;
font-size: 14px;
overflow-x: auto;
}
</style>
</head>
<body>
<p>Hi,</p>
<p>
Please find the latest report on new defect(s) introduced to <strong>Synchronet</strong>
found with Coverity Scan.
</p>
<ul>
<li><strong>New Defects Found:</strong> 113</li>
<li>
7 defect(s), reported by Coverity Scan earlier, were marked fixed in the recent build analyzed by Coverity Scan.
</li>
<li><strong>Defects Shown:</strong> Showing 20 of 113 defect(s)</li>
</ul>
<h3>Defect Details</h3>
<pre>
** CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3499 in alias()
_____________________________________________________________________________________________
*** CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3499 in alias()
3493
3494 if (*tp == 0) /* no alias value */
3495 continue;
3496 *tp = 0;
3497
3498 vp = tp + 1;
>>> CID 641219: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*vp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3499 SKIP_WHITESPACE(vp);
3500 truncsp(vp);
3501 if (*vp == 0) /* no value */
3502 continue;
3503
3504 if (*np == '*') {
** CID 641218: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 3761 in ctrl_thread()
/ftpsrvr.c: 4084 in ctrl_thread()
_____________________________________________________________________________________________
*** CID 641218: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 3761 in ctrl_thread()
3755 tp = np; /* terminator pointer */
3756 FIND_WHITESPACE(tp);
3757 if (*tp)
3758 *tp = 0;
3759
3760 dp = tp + 1; /* description pointer */
>>> CID 641218: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*dp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3761 SKIP_WHITESPACE(dp);
3762 truncsp(dp);
3763
3764 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
3765 continue;
3766
/ftpsrvr.c: 4084 in ctrl_thread()
4078 tp = np; /* terminator pointer */
4079 FIND_WHITESPACE(tp); 4080 if (*tp)
4081 *tp = 0;
4082
4083 dp = tp + 1; /* description pointer */
>>> CID 641218: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*dp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
4084 SKIP_WHITESPACE(dp); 4085 truncsp(dp);
4086
4087 if (stricmp(dp, BBS_HIDDEN_ALIAS) == 0)
4088 continue;
4089
** CID 641217: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 353 in smb_netaddr_type() /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 343 in smb_netaddr_type()
_____________________________________________________________________________________________
*** CID 641217: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 353 in smb_netaddr_type()
347 return NET_FIDO;
348 return NET_NONE;
349 }
350 if (p == str)
351 return NET_UNKNOWN;
352 p++;
>>> CID 641217: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
353 SKIP_WHITESPACE(p);
354 if (*p == 0)
355 return NET_UNKNOWN;
356
357 type = smb_get_net_type_by_addr(p);
358 if (type == NET_INTERNET && strchr(str, ' ') != NULL)
/tmp/sbbs-Jan-14-2026/src/smblib/smbstr.c: 343 in smb_netaddr_type()
337 const char* p;
338
339 if (str == NULL || IS_WHITESPACE(*str))
340 return NET_NONE;
341 if ((p = strchr(str, '@')) == NULL) {
342 p = str;
>>> CID 641217: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
343 SKIP_WHITESPACE(p);
344 if (*p == 0)
345 return NET_NONE;
346 if (smb_get_net_type_by_addr(p) == NET_FIDO)
347 return NET_FIDO;
348 return NET_NONE;
** CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 6561 in read_areafile_bbs()
_____________________________________________________________________________________________
*** CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 6561 in read_areafile_bbs()
6555 lprintf(LOG_ERR, "ERROR allocating memory for area #%u.", cfg.areas + 1);
6556 bail(1);
6557 return;
6558 }
6559 sprintf(tmp_code, "%-.*s", LEN_EXTCODE, p); 6560 tp = tmp_code;
>>> CID 641216: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
6561 FIND_WHITESPACE(tp);
6562 *tp = '\0';
6563 for (i = 0; i < scfg.total_subs; i++)
6564 if (!stricmp(tmp_code, scfg.sub[i]->code)) 6565 break;
6566 if (i < scfg.total_subs)
** CID 641215: (CONSTANT_EXPRESSION_RESULT)
/un_rep.cpp: 567 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 554 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 570 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 569 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 552 in sbbs_t::unpack_rep(char *)()
/un_rep.cpp: 555 in sbbs_t::unpack_rep(char *)()
_____________________________________________________________________________________________
*** CID 641215: (CONSTANT_EXPRESSION_RESULT)
/un_rep.cpp: 567 in sbbs_t::unpack_rep(char *)()
561 subscan[n].cfg |= SUB_CFG_NSCAN | SUB_CFG_YSCAN;
562 }
563 continue;
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) {
566 p = str + 6;
>>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
569 FIND_WHITESPACE(p);
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0) /un_rep.cpp: 554 in sbbs_t::unpack_rep(char *)()
548 if (!fgets(str, sizeof(str) - 1, fp)) 549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) {
551 p = str + 5;
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
>>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
554 FIND_WHITESPACE(p);
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
558 else if (strchr(p, 'a') || strchr(p, 'g'))
559 subscan[n].cfg |= SUB_CFG_NSCAN;
/un_rep.cpp: 570 in sbbs_t::unpack_rep(char *)()
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) {
566 p = str + 6;
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
569 FIND_WHITESPACE(p); >>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0)
573 subscan[n].ptr = 0;
574 else {
575 /* otherwise it should be set back [#ofmessages] back from the end of the message base. */
/un_rep.cpp: 569 in sbbs_t::unpack_rep(char *)()
563 continue;
564 }
565 if (strnicmp(str, "RESET ", 6) == 0) {
566 p = str + 6;
567 SKIP_WHITESPACE(p);
568 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
>>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
569 FIND_WHITESPACE(p);
570 SKIP_WHITESPACE(p);
571 /* If the [#ofmessages] is blank then the pointer should be set back to the start of the message base */
572 if (*p == 0)
573 subscan[n].ptr = 0;
574 else {
/un_rep.cpp: 552 in sbbs_t::unpack_rep(char *)()
546 if (fp != NULL) {
547 while (!feof(fp)) {
548 if (!fgets(str, sizeof(str) - 1, fp)) 549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) {
551 p = str + 5;
>>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
554 FIND_WHITESPACE(p);
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
/un_rep.cpp: 555 in sbbs_t::unpack_rep(char *)()
549 break;
550 if (strnicmp(str, "AREA ", 5) == 0) {
551 p = str + 5;
552 SKIP_WHITESPACE(p);
553 if ((n = resolve_qwkconf(atoi(p))) != INVALID_SUB) {
554 FIND_WHITESPACE(p); >>> CID 641215: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
555 SKIP_WHITESPACE(p);
556 if (strchr(p, 'D'))
557 subscan[n].cfg &= ~SUB_CFG_NSCAN;
558 else if (strchr(p, 'a') || strchr(p, 'g'))
559 subscan[n].cfg |= SUB_CFG_NSCAN;
560 else if (strchr(p, 'p'))
** CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1603 in check_elists()
_____________________________________________________________________________________________
*** CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1603 in check_elists()
1597 break;
1598 p = str;
1599 SKIP_WHITESPACE(p); 1600 if (*p == ';') /* Ignore Comment Lines */
1601 continue;
1602 tp = p;
>>> CID 641214: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1603 FIND_WHITESPACE(tp); 1604 *tp = '\0'; 1605 if (!stricmp(areatag, p)) {
1606 match = true; 1607 break;
1608 }
** CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3492 in alias()
_____________________________________________________________________________________________
*** CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /userdat.c: 3492 in alias()
3486 break;
3487 np = line;
3488 SKIP_WHITESPACE(np);
3489 if (*np == ';' || *np == 0) /* no name value, or comment */
3490 continue;
3491 tp = np;
>>> CID 641213: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
3492 FIND_WHITESPACE(tp);
3493
3494 if (*tp == 0) /* no alias value */
3495 continue;
3496 *tp = 0;
3497
** CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1531 in netmail_arealist()
_____________________________________________________________________________________________
*** CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 1531 in netmail_arealist()
1525 truncsp(str);
1526 p = str;
1527 SKIP_WHITESPACE(p);
1528 if (*p == 0 || *p == ';') /* Ignore Blank and Comment Lines */
1529 continue;
1530 tp = p; >>> CID 641212: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1531 FIND_WHITESPACE(tp);
1532 *tp = '\0';
1533 if (find_linked_area(p, addr) == SUB_NOT_FOUND) {
1534 if (strListFind(area_list, p, /* case_sensitive */ false) < 0)
1535 strListPush(&area_list, p);
1536 }
** CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 232 in key_name()
_____________________________________________________________________________________________
*** CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 232 in key_name()
226 *vp = NULL;
227
228 if (p == NULL)
229 return NULL;
230
231 /* Parse value name */
>>> CID 641211: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
232 SKIP_WHITESPACE(p);
233 if (*p == INI_COMMENT_CHAR)
234 return NULL;
235 if (*p == INI_OPEN_SECTION_CHAR)
236 return INI_NEW_SECTION;
237 equal = strchr(p, '=');
** CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /wordwrap.c: 211 in get_ws_len()
_____________________________________________________________________________________________
*** CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /wordwrap.c: 211 in get_ws_len()
205 {
206 struct section_len ret = {0, 0};
207
208 for (ret.bytes = 0; ; ret.bytes++) {
209 if (!buf[ret.bytes])
210 break;
>>> CID 641210: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)buf[ret.bytes] == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
211 if (!IS_WHITESPACE(buf[ret.bytes]))
212 break;
213 if (buf[ret.bytes] == '\t') {
214 ret.len++;
215 while ((ret.len + col) % 8)
216 ret.len++;
** CID 641209: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 83 in section_name() /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 87 in section_name()
_____________________________________________________________________________________________
*** CID 641209: (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 83 in section_name()
77 }
78
79 static char* section_name(char* p)
80 {
81 char* tp;
82
>>> CID 641209: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
83 SKIP_WHITESPACE(p);
84 if (*p != INI_OPEN_SECTION_CHAR)
85 return NULL;
86 p++;
87 SKIP_WHITESPACE(p);
88 tp = strrchr(p, INI_CLOSE_SECTION_CHAR); /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 87 in section_name()
81 char* tp;
82
83 SKIP_WHITESPACE(p);
84 if (*p != INI_OPEN_SECTION_CHAR)
85 return NULL;
86 p++;
>>> CID 641209: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
87 SKIP_WHITESPACE(p);
88 tp = strrchr(p, INI_CLOSE_SECTION_CHAR);
89 if (tp == NULL)
90 return NULL;
91 *tp = 0;
92 truncsp(p);
** CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1989 in parse_mail_address(const char *, char *, unsigned long, char *, unsigned long)()
_____________________________________________________________________________________________
*** CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1989 in parse_mail_address(const char *, char *, unsigned long, char *, unsigned long)()
1983
1984 /* Get the address */
1985 if ((tp = (char*)strchr(p, '<')) != NULL)
1986 tp++;
1987 else
1988 tp = (char*)p;
>>> CID 641208: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1989 SKIP_WHITESPACE(tp);
1990 sprintf(addr, "%.*s", (int)addr_len, tp);
1991 truncstr(addr, ">( ");
1992
1993 if (name != NULL) {
1994 SAFECOPY(tmp, p);
** CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 2496 in process_areamgr()
_____________________________________________________________________________________________
*** CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /sbbsecho.c: 2496 in process_areamgr()
2490 }
2491
2492 m = strlen(p);
2493 add_area = strListInit();
2494 del_area = strListInit();
2495 for (l = 0; l < m; l++) {
>>> CID 641207: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)p[l] == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2496 while (*(p + l) && IS_WHITESPACE(*(p + l))) l++;
2497 while (*(p + l) == CTRL_A) { /* Ignore kludge lines June-13-2004 */
2498 while (*(p + l) && *(p + l) != '\r') l++;
2499 continue;
2500 }
2501 if (!(*(p + l)))
** CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 118 in section_match()
_____________________________________________________________________________________________
*** CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /tmp/sbbs-Jan-14-2026/src/xpdev/ini_file.c: 118 in section_match() 112 /* Search for matches */
113 for (i = 0; names[i] != NULL && !found; i++)
114 for (j = 0; comps[j] != NULL && !found; j++) { 115 n = names[i];
116 SKIP_WHITESPACE(n);
117 c = comps[j];
>>> CID 641206: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*c == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
118 SKIP_WHITESPACE(c);
119 if (case_sensitive)
120 found = strcmp(n, c) == 0;
121 else
122 found = stricmp(n, c) == 0;
123 }
** CID 641205: (CONSTANT_EXPRESSION_RESULT)
/sbbsecho.c: 2225 in areamgr_command()
/sbbsecho.c: 2191 in areamgr_command()
/sbbsecho.c: 2224 in areamgr_command()
/sbbsecho.c: 2335 in areamgr_command()
/sbbsecho.c: 2156 in areamgr_command()
/sbbsecho.c: 2273 in areamgr_command()
/sbbsecho.c: 2192 in areamgr_command()
/sbbsecho.c: 2336 in areamgr_command()
/sbbsecho.c: 2250 in areamgr_command()
/sbbsecho.c: 2155 in areamgr_command()
/sbbsecho.c: 2274 in areamgr_command()
/sbbsecho.c: 2306 in areamgr_command()
/sbbsecho.c: 2249 in areamgr_command()
_____________________________________________________________________________________________
*** CID 641205: (CONSTANT_EXPRESSION_RESULT)
/sbbsecho.c: 2225 in areamgr_command()
2219 }
2220
2221 if (strnicmp(instr, "PKTPWD ", 7) == 0) {
2222 char pktpwd[FIDO_PASS_LEN + 1]; /* Packet password for this node */
2223 char* p = instr;
2224 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2225 SKIP_WHITESPACE(p);
2226 SAFECOPY(pktpwd, p);
2227 if (!stricmp(pktpwd, nodecfg->pktpwd)) {
2228 snprintf(str, sizeof str, "Your packet password was already set to '%s'."
2229 , nodecfg->pktpwd);
2230 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2191 in areamgr_command()
2185 return true;
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2191 FIND_WHITESPACE(p);
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2224 in areamgr_command()
2218 return true;
2219 }
2220
2221 if (strnicmp(instr, "PKTPWD ", 7) == 0) {
2222 char pktpwd[FIDO_PASS_LEN + 1]; /* Packet password for this node */
2223 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2224 FIND_WHITESPACE(p);
2225 SKIP_WHITESPACE(p);
2226 SAFECOPY(pktpwd, p);
2227 if (!stricmp(pktpwd, nodecfg->pktpwd)) {
2228 snprintf(str, sizeof str, "Your packet password was already set to '%s'."
2229 , nodecfg->pktpwd);
/sbbsecho.c: 2335 in areamgr_command()
2329 , str, /* dest: */ addr, /* src: */ NULL);
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2335 FIND_WHITESPACE(p);
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
/sbbsecho.c: 2156 in areamgr_command()
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
2155 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE; 2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++)
2161 if (stricmp(p, cfg.arcdef[u].name) == 0)
/sbbsecho.c: 2273 in areamgr_command()
2267 create_netmail(to, /* msg: */ NULL, "TIC File Password Change Request", str, /* dest: */ addr, /* src: */ NULL);
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2273 FIND_WHITESPACE(p);
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) { 2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
/sbbsecho.c: 2192 in areamgr_command()
2186 }
2187
2188 if (strnicmp(instr, "PASSWORD ", 9) == 0 || strnicmp(instr, "PWD ", 4) == 0) {
2189 char password[FIDO_SUBJ_LEN]; /* AreaMgr password for this node */
2190 char* p = instr;
2191 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2192 SKIP_WHITESPACE(p);
2193 SAFECOPY(password, p);
2194 if (strchr(password, ' ') != NULL) {
2195 snprintf(str, sizeof str, "Your AreaMgr password cannot contain spaces.");
2196 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
2197 create_netmail(to, /* msg: */ NULL, "AreaMgr Password Change Request", str
/sbbsecho.c: 2336 in areamgr_command()
2330 return true;
2331 }
2332
2333 if (strnicmp(instr, "ECHOSTATS ", 10) == 0) {
2334 char* p = instr;
2335 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2336 SKIP_WHITESPACE(p);
2337 echostat_t* stat = get_echostat(p, /* create: */ false);
2338 if (stat == NULL) {
2339 lprintf(LOG_INFO, "AreaMgr (for %s) EchoStats request for unknown echo: %s", faddrtoa(&addr), p);
2340 } else {
2341 FILE* fp;
/sbbsecho.c: 2250 in areamgr_command()
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
2249 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);
2255 lprintf(LOG_INFO, "AreaMgr (for %s) %s", faddrtoa(&addr), str);
/sbbsecho.c: 2155 in areamgr_command()
2149 lprintf(LOG_INFO, "AreaMgr (for %s) Changing name to: %s", faddrtoa(&addr), to);
2150 alter_config(nodecfg, "Name", to);
2151 }
2152
2153 if (strnicmp(instr, "COMPRESSION ", 12) == 0 || strnicmp(instr, "COMPRESS ", 9) == 0) {
2154 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2155 FIND_WHITESPACE(p);
2156 SKIP_WHITESPACE(p);
2157 if (!stricmp(p, "NONE"))
2158 nodecfg->archive = SBBSECHO_ARCHIVE_NONE; 2159 else {
2160 for (u = 0; u < cfg.arcdefs; u++) /sbbsecho.c: 2274 in areamgr_command()
2268 return true;
2269 }
2270
2271 if (strnicmp(instr, "NOTIFY ", 7) == 0) {
2272 char* p = instr;
2273 FIND_WHITESPACE(p);
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2274 SKIP_WHITESPACE(p);
2275 if (alter_config(nodecfg, "Notify", p)) { 2276 SAFEPRINTF2(str, "Your Notification Messages have been changed from '%s' to '%s'."
2277 , nodecfg->send_notify ? "ON" : "OFF", p);
2278 } else {
2279 SAFECOPY(str, "Error changing Notify Setting");
/sbbsecho.c: 2306 in areamgr_command()
2300 return true;
2301 }
2302
2303 // %RESCAN <area-tag> [R=<count> || D=<days>] 2304 if (strnicmp(instr, "RESCAN ", 7) == 0) {
2305 char* p = instr + 7;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2306 SKIP_WHITESPACE(p);
2307 char* tp = p;
2308 FIND_WHITESPACE(tp);
2309 if (*tp != '\0') {
2310 *tp = '\0';
2311 ++tp;
/sbbsecho.c: 2249 in areamgr_command()
2243 return true;
2244 }
2245
2246 if (strnicmp(instr, "TICPWD ", 7) == 0) {
2247 char ticpwd[SBBSECHO_MAX_TICPWD_LEN + 1]; /* TIC File password for this node */
2248 char* p = instr;
>>> CID 641205: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
2249 FIND_WHITESPACE(p);
2250 SKIP_WHITESPACE(p);
2251 SAFECOPY(ticpwd, p);
2252 if (!stricmp(ticpwd, nodecfg->ticpwd)) {
2253 snprintf(str, sizeof str, "Your TIC File password was already set to '%s'."
2254 , nodecfg->ticpwd);
** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()
_____________________________________________________________________________________________
*** CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /main.cpp: 5749 in bbs_thread()
5743 /* ToDo: Make ident timeout configurable */
5744 if (identify(&client_addr, inet_addrport(&client_addr), str, sizeof(str) - 1, /* timeout: */ 1)) {
5745 lprintf(LOG_DEBUG, "%04d %s [%s] Ident Response: %s", client_socket, client.protocol, host_ip, str);
5746 identity = strrchr(str, ':');
5747 if (identity != NULL) {
5748 identity++; /* skip colon */
>>> CID 641204: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*identity == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
5749 SKIP_WHITESPACE(identity);
5750 if (*identity)
5751 lprintf(LOG_INFO, "%04d %s [%s] Identity: %s", client_socket, client.protocol, host_ip, identity);
5752 }
5753 }
5754 sbbs->cp437_out(crlf);
** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
_____________________________________________________________________________________________
*** CID 641203: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 432 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;
428 continue;
429 }
430 if (strncmp(p, "Subject:", 8) == 0) {
431 p += 8;
>>> CID 641203: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
432 SKIP_WHITESPACE(p);
433 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
434 if (tp != NULL)
435 *tp = 0;
436 subject = p;
437 p += strlen(p) + 1;
/netmail.cpp: 422 in sbbs_t::qwktonetmail(_IO_FILE *, char *, char *, unsigned char)()
416 SAFECOPY(to, into);
417
418 // Parse QWKE Kludge Lines here:
419 while (p < end && *p != QWK_NEWLINE) {
420 if (strncmp(p, "To:", 3) == 0) {
421 p += 3;
>>> CID 641203: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
422 SKIP_WHITESPACE(p);
423 char* tp = strchr(p, QWK_NEWLINE); /* chop off at first CR */
424 if (tp != NULL)
425 *tp = 0;
426 SAFECOPY(to, p);
427 p += strlen(p) + 1;
** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()
_____________________________________________________________________________________________
*** CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT) /mailsrvr.cpp: 1960 in dns_blacklisted(int, const char *, xp_sockaddr *, char *, char *, char *)()
1954 continue;
1955
1956 sprintf(list, "%.100s", p);
1957
1958 /* terminate */
1959 tp = p;
>>> CID 641202: Integer handling issues (CONSTANT_EXPRESSION_RESULT)
>>> "(unsigned char)*tp == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1960 FIND_WHITESPACE(tp);
1961 *tp = 0;
1962
1963 found = rblchk(sock, prot, addr, p);
1964 }
1965 fclose(fp);
** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
_____________________________________________________________________________________________
*** CID 641201: (CONSTANT_EXPRESSION_RESULT)
/netmail.cpp: 1185 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1179 break;
1180 }
1181
1182 /* Get destination user address */
1183 if ((p = strrchr(rcpt_list[rcpt_count], '<')) != NULL) {
1184 p++;
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1185 SKIP_WHITESPACE(p);
1186 SAFECOPY(addr, p);
1187 p = strrchr(addr, '>');
1188 if (p == NULL) {
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
/netmail.cpp: 1195 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1189 bprintf(text[InvalidNetMailAddr], rcpt_list[rcpt_count]);
1190 break;
1191 }
1192 *p = 0;
1193 } else {
1194 p = rcpt_list[rcpt_count];
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1195 SKIP_WHITESPACE(p);
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
/netmail.cpp: 975 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
969 bprintf(text[InvalidNetMailAddr], p);
970 continue;
971 }
972 while (at > p && *at > ' ')
973 at--;
974 p = at;
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
975 SKIP_WHITESPACE(p);
976 uint16_t net_type = smb_netaddr_type(p);
977 if (net_type != NET_INTERNET) {
978 bprintf(text[InvalidNetMailAddr], p);
979 break;
980 }
/netmail.cpp: 1202 in sbbs_t::inetmail(const char *, const char *, int, smb_t *, smbmsg_t *, char **)()
1196 SAFECOPY(addr, p);
1197 }
1198 truncsp(addr);
1199
1200 /* Get destination user name */
1201 p = rcpt_list[rcpt_count];
>>> CID 641201: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1202 SKIP_WHITESPACE(p);
1203 SAFECOPY(name, p);
1204 p = strrchr(name, '<');
1205 if (!p)
1206 p = strrchr(name, '@');
1207 if (!p)
** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
/ftpsrvr.c: 1547 in ftpalias()
_____________________________________________________________________________________________
*** CID 641200: (CONSTANT_EXPRESSION_RESULT)
/ftpsrvr.c: 1534 in ftpalias()
1528
1529 while (!feof(fp)) {
1530 if (!fgets(line, sizeof(line), fp))
1531 break;
1532
1533 p = line; /* alias */
>>> CID 641200: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1534 SKIP_WHITESPACE(p);
1535 if (*p == ';') /* comment */
1536 continue;
1537
1538 tp = p; /* terminator */
1539 FIND_WHITESPACE(tp);
/ftpsrvr.c: 1547 in ftpalias()
1541 *tp = 0;
1542
1543 if (stricmp(p, alias)) /* Not a match */
1544 continue;
1545
1546 p = tp + 1; /* filename */
>>> CID 641200: (CONSTANT_EXPRESSION_RESULT) >>> "(unsigned char)*p == CP437_NO_BREAK_SPACE" is always false regardless of the values of its operands. This occurs as the logical second operand of "||".
1547 SKIP_WHITESPACE(p);
1548
1549 tp = p; /* terminator */
1550 FIND_WHITESPACE(tp);
1551 if (*tp)
1552 *tp = 0;
</pre>
<p>
<a href="
https://scan.coverity.com/projects/synchronet?tab=overview" class="button">View Defects in Coverity Scan</a>
</p>
<p>Best regards,</p>
<p>The Coverity Scan Admin Team</p>
<img class="logo" width="140" src="
https://scan.coverity.com/assets/BlackDuckLogo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg" />
</body>
</html>
----==_mimepart_69679e3a9f33a_26617a2afbc97ad9ac59811--
---
■ Synchronet ■ Vertrauen ■ Home of Synchronet ■ [vert/cvs/bbs].synchro.net
![https://scan.coverity.com/assets/BlackDuckLogo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg"](https://scan.coverity.com/assets/BlackDuckLogo-6697adc63e07340464201a2ad534d3d3e44f95d36edda20b140440d34f05372f.svg"){kind=link}